Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: improve the UX of profiler graph tooltip #17892

Merged
merged 3 commits into from
Sep 18, 2024
Merged

Minor: improve the UX of profiler graph tooltip #17892

merged 3 commits into from
Sep 18, 2024

Conversation

ShaileshParmar11
Copy link
Contributor

@ShaileshParmar11 ShaileshParmar11 commented Sep 17, 2024 •
edited
Loading

Minor: improve the UX of the profiler graph tooltip
image
image

Fixed: repetitive data was displayed in tooltip
image

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added safe to test Add this label to run secure Github workflows on PRs UI UI specific issues labels Sep 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 17, 2024 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
 64.31% (37352/58080) 40.96% (14784/36096) 43.07% (4507/10465)

chirag-madlani
chirag-madlani reviewed Sep 18, 2024
View reviewed changes
openmetadata-ui/src/main/resources/ui/src/utils/DataInsightUtils.tsx Outdated
@@ -144,19 +149,23 @@ export const CustomTooltip = (props: DataInsightChartTooltipProps) => {
active,
payload = [],
valueFormatter,
showFullTimestamp = false,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's have a axisFormatter to allow any time rendering instead restricting it to certain fixed typed

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ShaileshParmar11 ShaileshParmar11 enabled auto-merge (squash) September 18, 2024 13:05
@notion-workspace Notion Workspace
Copy link

Label appearing twice in System Metric widget

@ShaileshParmar11 ShaileshParmar11 merged commit ec6a662 into main Sep 18, 2024
16 checks passed
@ShaileshParmar11 ShaileshParmar11 deleted the aligne-tooltip-for-profiler branch September 18, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@karanh37 karanh37 Awaiting requested review from karanh37

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya

Assignees
No one assigned
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShaileshParmar11 @chirag-madlani